Latest develop fails to run SQL update

@Friendica Developers I have an error while the db update was running, Friendica was sending me an email about it.
The friendica developers released update 1274 recently,
but when I tried to install it, something went terribly wrong.
This needs to be fixed soon and I can't do it alone. Please contact a
friendica developer if you can not help me on your own. My database might be invalid.
The error message is
Errors encountered performing database changes: ALTER IGNORE TABLE `item` DROP INDEX `contactid_allowcid_allowpid_denycid_denygid`, DROP INDEX `uid_authorlink`, ...

On console I get this error:
Error 1296 occurred during database update:
Got error 64 'Temp file write failure' from InnoDB

I'm now back at my old commit so the instance can work again.
@Friendica Developers bug (x) develop (x) friendica (x) update (x)
$ df
Filesystem 1K-blocks Used Available Use% Mounted on
udev 10240 0 10240 0% /dev
tmpfs 792044 1476 790568 1% /run
/dev/md2 9712160 6439108 2756652 71% /
tmpfs 5120 0 5120 0% /run/lock
tmpfs 1584080 0 1584080 0% /run/shm
/dev/sda1 91387 62628 21857 75% /boot
/dev/md3 950374844 616979016 285096496 69% /var
tmpfs 3960216 1789340 2170876 46% /tmp

I think this okay?
Woah! There are tons of magick-* files for this virtual host's user. I have cleaned them up now.
Looking better now:
tmpfs 3960216 2076 3958140 1% /tmp
I try another update now. Thank you for the head up. :-)
I just wonder why imagick is writing its temporary files to /tmp/ ? Maybe the worker (CLI) has done this because of php.ini setting?
Is the error consistent? Can you run df -h to get human readable output? How much space takes your item table?
Okay, fixed here. The flooded `/tmp/` has caused this, to less sleep to figure this out by myself ... :-/ Thank you both again! @Hyp??li????e Pet????van (he/him) @Rebeka Catalina
Quick notice: Notice: Undefined index: url in /home/quix0r/NetBeansProjects/friendica/src/Object/Post.php on line 359. Maybe it does not exist at all in item table? @Hyp??li????e Pet????van (he/him) @Michael Vogel or maybe #tpyo ? uri does exist.
Yupp, no url there.
Now, after an update my right-side pane is gone. I found out that a style.css with display:none hid it.
Found a E_NOTICE here: Notice: Undefined index: title in /var/www/../src/Content/Text/BBCode.php on line 565
And another one: Notice: Undefined index: term in /var/www/../mod/filer.php on line 18
And 4 more:
Notice: Undefined property: stdClass::$type in /var/www/../src/Content/OEmbed.php on line 329
Notice: Undefined property: stdClass::$html in /var/www/../src/Content/OEmbed.php on line 169
Notice: Undefined property: stdClass::$type in /var/www/../src/Content/OEmbed.php on line 170
Notice: Undefined property: stdClass::$type in /var/www/../src/Content/OEmbed.php on line 171
Notice: Undefined property: stdClass::$type in /var/www/../src/Content/OEmbed.php on line 205
empty() or isset() work as well.
I find mine more clear ... ;-)
And I think I remember that it is lesser recommended for properties of stdClass objects.

And yet another E_NOTICE here: Notice: Undefined index: verb in /var/www/../src/Core/NotificationsManager.php on line 281. It origins from the system notification list view (/notifications/system.
@Hyp??li????e Pet????van (he/him) So, how to address this? Normally, I would check if the array element exists and if not, throw an exception. But that seems to be not wanted, it would however make it traceable where the error origins from (xdebug needs to be properly configured).
You really are a Java developer. :-D

I mostly just see if it is critical if a value isn't as expected. And I prefer failing silently - or at least without the danger of data loss.


:-) #Java teaches you to take really good care of your type-hints. But this will now lead away from the original scope of this thread, I guess.
And 2 more E_NOTICE:

Notice: Undefined index: emailcc in /var/www/../mod/item.php on line 192
Notice: Undefined variable: postopts in /var/www/../mod/item.php on line 632
Branch is ready, going to make a PR.
:D I should also fix the 2nd one ...
PR updated (and rebased ... ;) ).
And one more in addons: Notice: Undefined index: allow_api in /var/www/../addon/xmpp/xmpp.php on line 98
And even more while connecting to a #diaspora account:
Notice: Undefined index: cancel in /var/www/../mod/follow.php on line 22
Notice: Undefined index: addr in /var/www/../src/Protocol/Diaspora.php on line 2921
Notice: Undefined index: uprvkey in /var/www/../src/Protocol/Diaspora.php on line 3172
Notice: Undefined index: addr in /var/www/../src/Protocol/Diaspora.php on line 2921
PR #5404 is out to address these.
#xdebug let suppressed warnings/errors scream:
SCREAM: Error suppression ignored for
Warning: file_get_contents(/../phptmp/friendica/daemon.pid): failed to open stream: No such file or directory in /../friendica/bin/daemon.php on line 67

This whole thing can be done otherwise:
- remove the @ from it
- use file_exists() or is_readable() to check if file exists
- if so, read it, otherwise skip further parts

This leads to better code. In addition to that, maybe this particular thing can be encapsulated away in a class?
So, I think I rewrite this part a bit.
Some more (still there?) while requesting to follow an OStatus account:
Notice: Undefined index: body in /var/www/../src/Protocol/OStatus.php on line 1163
Notice: Undefined index: title in /var/www/../src/Protocol/OStatus.php on line 1916
Notice: Undefined index: guid in /var/www/../src/Protocol/OStatus.php on line 1925
Notice: Undefined index: tag in /var/www/../src/Model/Item.php on line 2787
Notice: Undefined index: tag in /var/www/../src/Model/Item.php on line 2796
Notice: Undefined index: attach in /var/www/../src/Protocol/OStatus.php on line 1372

And one from when the daemon is running:
Notice: Undefined offset: 0 in /../src/Model/GContact.php on line 970
Gee, getting more: ( ! ) Notice: Undefined index: marital in /../mod/profiles.php on line 250 and also later for line 314.
Interesting, that $item has really no element 'body':Image/photo cc !Friendica Developers
:-( Comments are not getting to mentioned forums ... Makes sense, of course. :-) Because the main post is not propagated. cc @Hyp☀️li🌷e Pet🌸van (he/him) @Michael Vogel
Editing a photo causes E_NOTICEs:

Notice: Undefined index: group_allow in /var/www/../mod/photos.php on line 356
Notice: Undefined index: contact_allow in /var/www/../mod/photos.php on line 357
Notice: Undefined index: group_deny in /var/www/../mod/photos.php on line 358
Notice: Undefined index: contact_deny in /var/www/../mod/photos.php on line 359
Another one when I view notifications:
Notice: Undefined index: verb in /var/www/../src/Core/NotificationsManager.php on line 276
Here, $it misses that element.